Added temporary verification for the number of ensemble members being one#13
Merged
KristianHMoller merged 2 commits intodmidk:mainfrom May 8, 2026
Conversation
|
I will review it |
elbdmi
reviewed
May 8, 2026
elbdmi
left a comment
elbdmi
left a comment
There was a problem hiding this comment.
Looks good to me for now. Again as in the previous pr we could have a small test just checking that it works correctly but it is fine. Since this is a temporary solution, a TODO or linked issue for future multi-ensemble support would also make it easier to remove later.
elbdmi
approved these changes
May 8, 2026
Contributor
Author
Great idea! I have created an issue: #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
sunflowaccepts only a single ensemble member.Now, the code checks the value of
ens_membersand exits if it is different from one.To be removed once support for multiple ensemble members is included.